So to my elves.
Malekith the Witch king- The real evil baddie in the WHFB universe. He is also a sharp militry mind and proved this both before and after his fall from grace. Heck, he was even best chum with Grombrindal!
Caledor I - The elven prince who managed to rally a federation and raise an army against Malekiiths disciplined and battle hardened Nagarythians. He ended up kicking Mallie and his buddies away from Ulthuan.
Tethlis the Slayer - Phoenix king who cast out the dark elf after their first return. Even the dark elves gurdgingly give him some creed. A meticilous planner and organizer aswell as charismatic field commander. Planned an invasion of Naggaroth before his untimely and misty demise.
He also laid the foundation for the militia system by ordering all citices to have muster fields for military training.
Prince Mentheus of Caledor - General under Phoenix king Morvael under the second dark elf invasion of Ulthuan. He managed to halt the attackers by the Griffon gate. Mentheus then organized the militia system were all male highh elves serve iin one of the regiments and spend some part of the year under arms. He turned the tide and pressed the Dark elves back, finishing with laying siege and finally storming the dark elves last stronnghold on Ulthuan, Anlec. Sadly, Mentheus perished in the fighting. However, Mentheus also penned a number of books on warfare and tactics that are preserved in the Library of Hoeth as some of the finest books on tactics and warfare.